iotaledger / iota-rust-sdk

Apache License 2.0
0 stars 0 forks source link

struct Event inconsistent with iota repo #14

Open Thoralf-M opened 3 weeks ago

Thoralf-M commented 3 weeks ago
pub struct Event {
    pub package_id: ObjectId,
    pub module: Identifier,
pub struct Event {
    pub package_id: ObjectID,
    pub transaction_module: Identifier,

iota repo has transaction_ as name, is this fine or do we want to align?

Thoralf-M commented 3 weeks ago

There are even more inconsistencies

pub struct GasPayment {
    pub objects: Vec<ObjectReference>,
    pub owner: Address,
    #[cfg_attr(feature = "serde", serde(with = "crate::_serde::ReadableDisplay"))]
    #[cfg_attr(feature = "schemars", schemars(with = "crate::_schemars::U64"))]
    pub price: u64,
    #[cfg_attr(feature = "serde", serde(with = "crate::_serde::ReadableDisplay"))]
    #[cfg_attr(feature = "schemars", schemars(with = "crate::_schemars::U64"))]
    pub budget: u64,
}

iota repo:

pub struct GasData {
    pub payment: Vec<ObjectRef>,
    pub owner: IotaAddress,
    pub price: u64,
    pub budget: u64,
}
pub struct Transaction {
    pub kind: TransactionKind,
    pub sender: Address,
    pub gas_payment: GasPayment,
    pub expiration: TransactionExpiration,
}

iota repo:

pub struct TransactionDataV1 {
    pub kind: TransactionKind,
    pub sender: IotaAddress,
    pub gas_data: GasData,
    pub expiration: TransactionExpiration,
}