iotaledger / iota-sdk

The IOTA SDK provides developers with a seamless experience to develop on IOTA by providing account abstractions and clients to interact with node APIs.
Apache License 2.0
57 stars 41 forks source link

NodeJs: sweet improvements :strawberry: #2161

Closed Alex6323 closed 6 months ago

Alex6323 commented 6 months ago

Description of change

This PR:

UPDATE: after a call we decided to remove this alias mismatch detection from this PR, because we don't think there's a real problem with the builder overwriting the alias stored in the db since this is non-critical data. I kept the other changes unrelated to the wallet alias, which are:

Links to any relevant issues

Fixes #2016

How the change has been tested

Integration tests.

DaughterOfMars commented 6 months ago

Shouldn't we just overwrite it? I mean it's just an alias.

Alex6323 commented 6 months ago

Shouldn't we just overwrite it? I mean it's just an alias.

could maybe be used to trick someone to enter the stronghold password ... I would be conservative here and not do that. I'ld rather have some explicit command that says change_alias or something (similar to change_stronghold_password).