iotaledger / iota-sdk

The IOTA SDK provides developers with a seamless experience to develop on IOTA by providing account abstractions and clients to interact with node APIs.
Apache License 2.0
57 stars 41 forks source link

[Bug]: Expiration unlock condition 'slot' field #2217

Closed msarcev closed 5 months ago

msarcev commented 6 months ago

Issue description

The field in the deserialized EUC is slot while the typescript models define slotIndex

{"type":3,"returnAddress":{"type":8,"accountId":"0x21c983484baec0435205ba1a4c31ef0e66565fd84c93b086ca4c91ec8b9a65e5"},"slot":17724}

VS

declare class ExpirationUnlockCondition extends UnlockCondition {
    readonly returnAddress: Address;
    readonly slotIndex: SlotIndex;
    constructor(returnAddress: Address, slotIndex: SlotIndex);
}

Version

2.0

Expected behaviour

N/A

Actual behaviour

N/A

Can the issue reliably be reproduced?

Yes

Steps to reproduce the issue

No response

Errors

No response

Duplicate declaration

thibault-martinez commented 6 months ago

https://github.com/iotaledger/iota-sdk/pull/2215 ?

thibault-martinez commented 5 months ago

Can/Should this be closed?