iotaledger / iota-wiki

IOTA Wiki

https://wiki.iota.org

Other

112 stars 273 forks source link

Add a get IRC27NFT Metadata guide #1583

Closed Ginowine closed 3 weeks ago

Ginowine commented 1 month ago

Description of change

This PR creates a new page titled "Get NFT Metadata". The page explains how to utilize the getIRC27NFTData function within a smart contract to fetch information about a specific IRC27 NFT on the IOTA Network

Links to any relevant issues

fixes #1571

Type of change

Documentation Enhancement

Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own changes
[x] I have made sure that added/changed links still work
[ ] I have commented my code, particularly in hard-to-understand areas

Ginowine commented 1 month ago

I have addressed all the review suggestions. Please take a look and let me know if there are any further changes needed.

Ginowine commented 1 month ago

I noticed this URL (../../../reference/magic-contract/ISCSandbox/#getirc27nftdata) on the page is causing the test/build to fail. Trying to get the right URL. Will send a new PR after fixing it

Ginowine commented 1 month ago

Ok, thanks for the suggestions. I'll implement them and send a new push request.

Ginowine commented 1 month ago

@Dr-Electron, I have updated the doc to follow your suggestions. Please take a look and let me know. Thanks.

lucas-tortora commented 1 month ago

@Dr-Electron, I have updated the doc to follow your suggestions. Please take a look and let me know. Thanks.

@Ginowine, could you fix the broken links in the test workflow?

Ginowine commented 1 month ago

@lucas-tortora, I fixed the link pointing to the mint-nft.md file. For the other link errors below, Kevin said the preview doesn’t work because my fork doesn’t know iota-wiki deployment secrets and that we can ignore it as long as the build workflow succeeds.

../../../reference/magic-contract/ERC721NFTs.md/#tokenuri (resolved as: /isc/v1.3-alpha/how-tos/reference/magic-contract/ERC721NFTs.md/)

The below link was provided by Kevin.

../../../reference/magic-contract/ERC721NFTs.md#tokenuri

It would be great if I could get the correct link to use.

Ginowine commented 4 weeks ago

Thank you so much, @lucas-tortora, for the suggestions on how to fix the build. Noted.