search

iotaledger / iota.py

PyOTA: The IOTA Python API Library
https://docs.iota.org/
MIT License
345 stars 124 forks source link

Add pypy3 support #93

Open mlouielu opened 6 years ago

mlouielu commented 6 years ago

In my test, pypy3 will improve the hash function performance about 2x.

The main problem is pysha3 currently can't built on pypy3, but changing to use pycryptodome can support on pypy3, and pass the full test cases.

todofixthis commented 6 years ago

Hey @mlouielu thanks for looking into this!

What is the issue you run into when building pysha3? Is it related to this? https://github.com/tiran/pysha3/issues/13

mlouielu commented 6 years ago

@todofixthis I'm using pypy3 to build pysha3, didn't come up with pysha3#13. The issue is related to this one: https://bitbucket.org/pypy/pypy/issues/2687/pypy3-is-missing-pystrhexh-breaking-pysha3

todofixthis commented 6 years ago

Gotcha. I see that issue was filed recently, and it was given high priority.

My preference would be to wait and see if the pypy3 developers address the issue. Let's check on this in a couple of weeks; if there's no acknowledgement from the pypy3 team, then we can investigate swapping out the crypto library.