search

iotaledger / iri

IOTA Reference Implementation
Other
1.15k stars 370 forks source link

Misspelled neighbor can't be removed by NeighborRouter #1552

Open TeeVeeEss opened 5 years ago

TeeVeeEss commented 5 years ago

Bug description

tcp://example.com:15600 is added as new neighbor using iota-pm. A typo is made and tcp://exampple.com:15600 is added and accepted without warnings or errors. The new neighbor is obviously not syncing. After spotting the typo the neighbor tcp://exampple.com:15600 is removed using iota-pm, standard reaction "Succesfully removed". The neighbor is however not removed, it keeps popping up. Only a restart on IRI wil force the removal of this misspelled neighbor, because it was not (yet) added to the config.

IRI version

1.8.0-RELEASE

Hardware Spec

4 cores 8 GB RAM

Steps To Reproduce

  1. add misspelled neighbor
  2. remove misspelled neighbor

Expected behaviour

Neighbor should be deleted.

Actual behaviour

Neighbor was not deleted from list.

Errors

[XNIO-1 task-12] WARN NeighborRouter:824 - unable to remove neighbor tcp://exampple.com:15600 as IP address couldn't be resolved 07/29 20:12:18.517 [XNIO-1 task-12] INFO API:500 - Can't remove neighbor tcp://exampple.com:15600: domain couldn't be resolved to its IP address

jakubcech commented 5 years ago

Thanks. We should fix a test in iri-regression so that it calls an already removed neighbor and then we'll know if we need to fix this in IRI.