Test ZMQ topics - Githubissues

iotaledger / iri

IOTA Reference Implementation

Other

1.15k stars 370 forks source link

Test ZMQ topics #1598

Open GalRogozinski opened 5 years ago

GalRogozinski commented 5 years ago

Description

For each zmq topic we should have a regression test that ascertains it continues to work

Motivation

So we don't accidentally remove zmq topics

Issues / Scenarios

See each topic in https://github.com/iotaledger/iri/blob/dev/src/main/java/com/iota/iri/zmq/README.md

How to test for this

We can hook into already existing tests and just add the necessary steps. Since spinning up a cluster takes time, we don't want to make the regression tests take much longer time.

DyrellC commented 4 years ago

I'm going to compile a quick list of zmq topics and where would be the most appropriate place for those tests to be integrated machine wise. I'll ping you @GalRogozinski when I've figured out where I plan to put them

DyrellC commented 4 years ago

[ ] mctn - Number of transactions walked - GTTA - machine 1
[ ] lmi - Latest Milestone Index - Milestone test - machine 6
[ ] lmsi - Latest Milestone Solid Index - Milestone test - machine 6
[ ] lmhs - Latest solid milestone hash - Milestone test - machine 6
[ ] sn - Solidified transaction - transaction tests - machine 2
[ ] sn_trytes - solidified transaction trytes - transaction tests - machine 2
[ ] tx - New transaction - transaction tests - machine 2
[ ] tx_trytes - new transaction trytes - transaction tests - machine 2

@GalRogozinski

GalRogozinski commented 4 years ago

You are just missing the <Address> topic. See ZMQ README and https://github.com/iotaledger/iri/blob/d5252270594d11421bf53b912d913369a1438c2e/src/main/java/com/iota/iri/service/milestone/impl/MilestoneServiceImpl.java#L422