iotaledger / iri

IOTA Reference Implementation

Other

1.15k stars 370 forks source link

Only cache after exists check passes #1774

Closed GalRogozinski closed 4 years ago

GalRogozinski commented 4 years ago

Description

When a node sees a transaction it may have seen before it won't insert it into the cache to not override the existing transaction.

Fixes a problem where we may be switching instances of txs and thus not setting them solid, because we skip the updateStatus method

Type of change

Please delete options that are not relevant.

Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

TBD

Checklist:

Please delete items that are not relevant.

[x] My code follows the style guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

GalRogozinski commented 4 years ago

Current Testing doesn't show results for the devnet problem But maybe the PR is still good?