Txs that were being quick set solid were not being persisted upon release from cache.
This change ensures that updates are always persisted by assuming responsibility to always call tvm.update
Also, fixes is a possible race condition with tvm.shouldPersist and cache metric fields.
Type of change
Please delete options that are not relevant.
Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
How Has This Been Tested?
Existing and new unit tests that assert persistence pass.
Buildkite will run reg tests :)
Checklist:
Please delete items that are not relevant.
[x] My code follows the style guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
DyrellC
commented
4 years ago
Description
Txs that were being quick set solid were not being persisted upon release from cache. This change ensures that updates are always persisted by assuming responsibility to always call
tvm.updateAlso, fixes is a possible race condition withtvm.shouldPersistand cache metric fields.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
Please delete items that are not relevant.