When a transaction fails to get applied to the ledger due to the need to correct some form of corruption in ledger state, we should not remove it from the seen milestones queue so that the attempts to reset the milestone don't stop.
Type of change
Bug fix (a non-breaking change which fixes an issue)
How the change has been tested
In ICC tests when milestone failed to solidify it continued to try to reset the corruption rather than trying once and removing it from the seen milestones queue.
Change checklist
[x] My code follows the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] New and existing unit tests pass locally with my changes
Description of change
When a transaction fails to get applied to the ledger due to the need to correct some form of corruption in ledger state, we should not remove it from the seen milestones queue so that the attempts to reset the milestone don't stop.
Type of change
How the change has been tested
In ICC tests when milestone failed to solidify it continued to try to reset the corruption rather than trying once and removing it from the seen milestones queue.
Change checklist