search

iotconnectivity / python-gsmmodem-manager

A multi-platform framework for communicating and interacting with 2G/3G/4G usb modems
GNU General Public License v3.0
16 stars 5 forks source link

Replaced ATZ with AT^RESET for the reset_modem Function #2

Closed genesis2600 closed 5 years ago

genesis2600 commented 5 years ago

Changed the reset command, to AT^RESET like we agreed on yesterday.

genesis2600 commented 5 years ago

Hello @fontanon, This is indeed an oversight from my part. The AT^RESET command is not part of the Hayes command set. I changed the concerned section back to its original state, did however, as requested, change the function name. I would now after reading the 3GPP TS 27.007 V16.2.0 documentation, also agree that the command might be useful as it resets the modem to its default values.

I also added a new function into the Huawei specific part which does an electric reset, which might be better adapted for certain situations, using the AT^RESET command. You can find the command in the Huawei AT Command Interface Specification under section 10.16.

genesis2600 commented 5 years ago

My bad, seems like I approved the change myself...

fontanon commented 5 years ago

No worries, congrats!