envestcc commented 2 months ago

Description

Fixes #4158

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] make test

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.76%. Comparing base (e1f0636) to head (75c9513). Report is 222 commits behind head on master.

:exclamation: Current head 75c9513 differs from pull request most recent head f381099. Consider uploading reports for the commit f381099 to get more accurate results

Files	Patch %	Lines
blockchain/blockdao/blockindexer.go	50.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4217 +/- ## ========================================== + Coverage 75.38% 76.76% +1.37% ========================================== Files 303 340 +37 Lines 25923 29273 +3350 ========================================== + Hits 19541 22470 +2929 - Misses 5360 5698 +338 - Partials 1022 1105 +83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

iotexproject / iotex-core

[blockdao] Fix program unstopable when blockdao is checking indexer #4217