iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go.
https://iotex.io
Apache License 2.0
1.55k stars 322 forks source link

[evm] implement EIP-6780 SELFDESTRUCT only in same transaction #4218

Open dustinxie opened 2 months ago

dustinxie commented 2 months ago

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 36.20690% with 37 lines in your changes missing coverage. Please review.

Project coverage is 76.69%. Comparing base (d716bb9) to head (24e6bd2). Report is 55 commits behind head on master.

:exclamation: Current head 24e6bd2 differs from pull request most recent head 411da31

Please upload reports for the commit 411da31 to get more accurate results.

Files Patch % Lines
action/protocol/execution/evm/evmstatedbadapter.go 30.00% 30 Missing and 5 partials :warning:
action/protocol/execution/evm/evm.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4218 +/- ## ========================================== + Coverage 76.51% 76.69% +0.18% ========================================== Files 340 340 Lines 29273 29303 +30 ========================================== + Hits 22397 22475 +78 + Misses 5761 5719 -42 + Partials 1115 1109 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud