iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go. An ultra-efficient EVM blockchain offering 1000 TPS with instant 1-block finality. Perfect for DeFi, DePIN tokenomics, Identities, and any trusted logic requiring Web3 composability

https://iotex.io

Apache License 2.0

1.55k stars 324 forks source link

[dispatcher] refactor dispatcher to simplify adding new message #4232

Closed envestcc closed 1 month ago

envestcc commented 5 months ago

Description

The main purpose of refactoring the dispatcher is to make it easier to add more messages. Specific changes include:

Extracting the msg_queue component to manage the queue worker and message mappping
Using a unify message structure to simplify the processing of different types of messages

Type of change

Please delete options that are not relevant.

[x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] make test

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 5 months ago

Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud