iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go.

https://iotex.io

Apache License 2.0

1.55k stars 322 forks source link

[action] Transfering delegate ownership, add CandidateTransferOwnership #4236

Closed millken closed 1 month ago

millken commented 2 months ago

Description

Transfering delegate ownership to a new address PART 1

protobuf changes: https://github.com/iotexproject/iotex-proto/pull/147/files

Related PR: https://github.com/iotexproject/iotex-core/pull/4236 https://github.com/iotexproject/iotex-core/pull/4239 https://github.com/iotexproject/iotex-core/pull/4245 https://github.com/iotexproject/iotex-core/pull/4250

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

dustinxie commented 2 months ago

also you'll need to add this new action type into envelope's Proto and LoadProto

millken commented 2 months ago

also you'll need to add this new action type into envelope's Proto and LoadProto

added in #4250

dustinxie commented 2 months ago

also you'll need to add this new action type into envelope's Proto and LoadProto

added in #4250

4250 is for ioctl, this change should be added in this PR

dustinxie commented 2 months ago

add guarding test case in rlp_tx_test.go

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud