millken commented 5 months ago

Description

In the last PR #4239, we have implemented GetIdentifier().

This which replaced all Bucket (CreateStake/Unstake/DepositToStake/Restake/ChangeCandidate) and IIP13 contractIndex places with the new GetIdentifier()

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 63.52941% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 76.94%. Comparing base (cc526cd) to head (e8d702a). Report is 17 commits behind head on master.

:exclamation: Current head e8d702a differs from pull request most recent head 7092b43

Please upload reports for the commit 7092b43 to get more accurate results.

Files	Patch %	Lines
...ol/staking/handler_candidate_transfer_ownership.go	0.00%	41 Missing :warning:
action/protocol/staking/handlers.go	61.53%	9 Missing and 1 partial :warning:
action/protocol/staking/candidate_center.go	94.28%	2 Missing and 2 partials :warning:
action/protocol/staking/candidate.go	87.50%	1 Missing and 1 partial :warning:
action/protocol/staking/candidate_statereader.go	33.33%	2 Missing :warning:
action/protocol/staking/protocol.go	71.42%	1 Missing and 1 partial :warning:
.../protocol/staking/handler_candidate_endorsement.go	50.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4245 +/- ## ========================================== - Coverage 77.02% 76.94% -0.09% ========================================== Files 342 345 +3 Lines 29406 29622 +216 ========================================== + Hits 22651 22793 +142 - Misses 5650 5716 +66 - Partials 1105 1113 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.