iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go.
https://iotex.io
Apache License 2.0
1.55k stars 322 forks source link

[action] pass tx type to ToEthTx() method #4246

Open dustinxie opened 2 months ago

dustinxie commented 2 months ago

Description

We are going to implement EIP-1559, which introduced a new DynamicFeeTx type. Together with the existing LegacyTx and AccessListTx (also going to be enabled soon), we now have 3 types of Ethereum txs that native action can possibly convert to. So need to pass in the Ether tx type to ToEthTx() method.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud