iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go.
https://iotex.io
Apache License 2.0
1.55k stars 322 forks source link

[api] readState support to non-rolldpos mode #4247

Closed envestcc closed 1 month ago

envestcc commented 2 months ago

Description

STANDALONE and NOOP is easy to use than ROLLDPOS in writing e2etest, and readState is used to checking things in testing. But it's only supported in ROLLDPOS.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.97%. Comparing base (cc526cd) to head (33382b8). Report is 5 commits behind head on master.

Files Patch % Lines
api/coreservice.go 75.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4247 +/- ## ========================================== - Coverage 77.02% 76.97% -0.05% ========================================== Files 342 343 +1 Lines 29406 29438 +32 ========================================== + Hits 22651 22661 +10 - Misses 5650 5670 +20 - Partials 1105 1107 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.