iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go.
https://iotex.io
Apache License 2.0
1.55k stars 322 forks source link

[action] add claim reward account #4277

Closed saitofun closed 3 weeks ago

saitofun commented 1 month ago

Description

  1. add address field to action.ClaimFromRewardingFund to assign the address claim reward to (6efdfb2)
  2. fix unit tests (426ba7d)
  3. add claim to arg for ioctl action claim (fab352e)
  4. check address when handle claim reward, if address is empty, default use action's caller address.(2aea4c5)

Fixes #(issue)

Type of change

How Has This Been Tested?

Test Configuration:

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.08%. Comparing base (cc526cd) to head (426ba7d). Report is 15 commits behind head on master.

:exclamation: Current head 426ba7d differs from pull request most recent head dc84eb7

Please upload reports for the commit dc84eb7 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4277 +/- ## ========================================== + Coverage 77.02% 77.08% +0.05% ========================================== Files 342 344 +2 Lines 29406 29528 +122 ========================================== + Hits 22651 22762 +111 - Misses 5650 5661 +11 Partials 1105 1105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud