iotexproject / iotex-core

Official implementation of IoTeX blockchain protocol in Go. An ultra-efficient EVM blockchain offering 1000 TPS with instant 1-block finality. Perfect for DeFi, DePIN tokenomics, Identities, and any trusted logic requiring Web3 composability
https://iotex.io
Apache License 2.0
1.55k stars 324 forks source link

[workingset] purge actpool when run action fails #4317

Closed dustinxie closed 3 months ago

dustinxie commented 3 months ago

Description

when runAction() fails, the tx got stuck, and prevent block from being produced. So the erroneous tx (and other pending tx from same sender) should be removed from actpool

Fixes #(issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 75.83%. Comparing base (cc526cd) to head (3a8fbe6). Report is 50 commits behind head on master.

:exclamation: Current head 3a8fbe6 differs from pull request most recent head 6d17757

Please upload reports for the commit 6d17757 to get more accurate results.

Files Patch % Lines
state/factory/workingset.go 34.78% 12 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4317 +/- ## ========================================== - Coverage 77.02% 75.83% -1.20% ========================================== Files 342 360 +18 Lines 29406 30183 +777 ========================================== + Hits 22651 22888 +237 - Misses 5650 6157 +507 - Partials 1105 1138 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.