search

iotile / coretools

Core python tools for building and using IOTile based devices
GNU General Public License v3.0
14 stars 7 forks source link

Audit codebase for any direct python-iotile-cloud `Api` usage and ensure it respects verify=False #953

Closed timburke closed 4 years ago

timburke commented 4 years ago

We need to verify that we have found all of our direct use of the Api object in CoreTools and are not missing any places that need to updated to support self-signed TLS certificates.

timburke commented 4 years ago

Here are the places that we found during an initial nonexhaustive search:

https://github.com/iotile/coretools/blob/master/iotile_ext_cloud/iotile/cloud/cloud.py#L51 https://github.com/iotile/coretools/blob/master/iotile_ext_cloud/iotile/cloud/config.py#L54

dvksirin commented 4 years ago

It seems Api class in coretools repo is only used in two places mentioned above. One more place should be updated to support self-signed certificates: https://github.com/iotile/coretools/blob/master/iotile_ext_cloud/iotile/cloud/apps/ota_updater.py#L31

timburke commented 4 years ago

Got it, understood.