iotile / typedargs

API typechecking and command line shell generation package
GNU Lesser General Public License v3.0
1 stars 2 forks source link

Refactor recursive builtin dict and list types to be generic type class factories #74

Closed timburke closed 4 years ago

timburke commented 4 years ago

The current implementation has a Build function that returns a type class. We should use a similar method to have a Build function that returns a type class specialized for the generic parameter values as described in #70.

The goal should be that when we encounter a complex type we instantiate the corresponding concrete type class and use that instead.

dvksirin commented 4 years ago

@timburke It seems this issue does not require any extra changes in typedargs. Complex types Dict[t, t] and List[t] are already mapped to our internal map and list types, these classes are used to instantiate required type objects.

timburke commented 4 years ago

Great, we can close this then.