search

iou90 / react-native-autoheight-webview

An auto height webview for React Native
ISC License
492 stars 162 forks source link

Use ViewPropTypes from 'deprecated-react-native-prop-types' #228

Closed danieldegrassi closed 2 years ago

danieldegrassi commented 2 years ago

I'm getting this warning:

ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'

stevekuznetsov commented 2 years ago

On my end, the version of RN is new enough that this causes a failure in Metro (?) and renders the app broken.

$ react-native --version
8.0.2
iou90 commented 2 years ago

It should be fixed on v1.6.2. (https://github.com/iou90/react-native-autoheight-webview/releases/tag/v1.6.2)

mauricekleine commented 2 years ago

@iou90 @stevekuznetsov this change is breaking my app:

TypeError: undefined is not a function (near '..._deprecatedReactNativePropTypes.default.shape...')

It looks like deprecated-react-native-prop-types is not a drop-in replacement for prop-types - e.g. there's no .shape exported.

I had to downgrade to v1.6.1 to get my app to work again

danieldegrassi commented 2 years ago

Likewise.

BS-FastwebIT commented 2 years ago

same issue...

MykhailoButkevych-PE commented 2 years ago

Same issue

stevekuznetsov commented 2 years ago

Oops, sorry all - I think https://github.com/iou90/react-native-autoheight-webview/pull/235 fixes it, but would appreciate a check!

iou90 commented 2 years ago

"deprecatedReactNativePropTypes.default.shape is not a function" should be fixed on v1.6.3. (https://github.com/iou90/react-native-autoheight-webview/releases/tag/v1.6.3) @MykhailoButkevych-PE @BS-FastwebIT @danieldegrassi @mauricekleine