ioulian / next-io-ghent-starter

Next.js starter kit for iO Ghent
https://ioulian.github.io/next-io-ghent-starter/
4 stars 0 forks source link

Update eslint json #12

Closed ioulian closed 1 year ago

ioulian commented 1 year ago
{
  "extends": "next/core-web-vitals",
  "settings": {
    "next": {
      "rootDir": "packages/visitor-app/"
    }
  },
  "rules": {
    "import/order": ["error", {
      "groups": ["builtin", "external", "internal", "parent", "sibling", "index"],
      "pathGroups": [
        {
          "pattern": "@common/**",
          "group": "internal",
          "position": "after"
        },
        {
          "pattern": "@WBTypes/**",
          "group": "internal",
          "position": "before"
        }
      ],
      "newlines-between": "always",
      "pathGroupsExcludedImportTypes": ["builtin"]
    }]
  }
}

And fix code then

ioulian commented 1 year ago
{
  "plugins": [
    "@typescript-eslint"
  ],
  "extends": [
    "next/core-web-vitals",
    "plugin:@typescript-eslint/recommended"
  ],
  "settings": {
    "next": {
      "rootDir": "packages/visitor-app/"
    }
  },
  "rules": {
    "@typescript-eslint/no-unused-vars": "error",
    "@typescript-eslint/no-explicit-any": "off",
    "@typescript-eslint/no-non-null-assertion": "off",
    "import/order": [
      "error",
      {
        "groups": [
          "builtin",
          "external",
          "internal",
          "parent",
          "sibling",
          "index"
        ],
        "pathGroups": [
          {
            "pattern": "@common/**",
            "group": "internal",
            "position": "after"
          },
          {
            "pattern": "@WBTypes/**",
            "group": "internal",
            "position": "before"
          },
          {
            "pattern": "@/**",
            "group": "internal",
            "position": "after"
          }
        ],
        "newlines-between": "always",
        "pathGroupsExcludedImportTypes": [
          "builtin"
        ]
      }
    ]
  }
}
timdujardin commented 1 year ago

Fixed in https://github.com/ioulian/next-io-ghent-starter/commit/945ccd60ebd210aa09e0248e753e5b0acdab63e7.