search

ioulian / next-io-ghent-starter

Next.js starter kit for iO Ghent
https://ioulian.github.io/next-io-ghent-starter/
4 stars 0 forks source link

ButtonGroup component: make sure visual order matches DOM order #24

Closed timdujardin closed 1 year ago

timdujardin commented 1 year ago

https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction#accessibility_concerns

flex-direction: ${({ $alignRight }) => ($alignRight ? "row-reverse" : "row")};

The buttons inside the group should effectively be reordered semantically and not only visually, as a rule of thumb we should prevent using row-reverse and column-reverse since it breaks visual and DOM connection.

ioulian commented 1 year ago

fixed in b212ed5f7783ce1d97ed533fac8f7dbe14eecc8e