iov-one / iov-core

Client library for secure key management and multi-blockchain communication
https://iov-one.github.io/iov-core-docs/
Apache License 2.0
198 stars 18 forks source link

Upgrade to new bnsd (0.10.0) #645

Closed ethanfrey closed 5 years ago

ethanfrey commented 5 years ago

Basically, regenerating bns codecs from the new protobuf definitions and making needed changes.

Update: bnsd 0.10.0 docker image is available

The binary format is breaking, to make it forward-compatible, so this means a iov-core code will support either < 0.10.0 or >= 0.10.0, which should be made very explicit in the README. https://github.com/iov-one/weave/pull/241

There are some breaking changes that will affect the generated code, such as:

ethanfrey commented 5 years ago

@webmaster128 as discussed, please try compiling the protobuf files from 0.10.0 soon, to see if this causes any issues (as they added optional gogoproto extensions). If there are issues, we can take a few days to find a solution upstream, so you can just use the file and work on the code.