Return iovns version info in abci_info

iov-one / iovns

The IOV Name Service built on cosmos-sdk

Apache License 2.0

11 stars 13 forks source link

Return iovns version info in abci_info #1

Open davepuchyr opened 4 years ago

davepuchyr commented 4 years ago

https://github.com/iov-one/weave/pull/1194 was a really helpful feature that should be incorporated into iovns

orkunkl commented 4 years ago

Apparently we don't need extra implementation for this. Cosmos SDK handles it. Check related the configuration code: http://github.com/iov-one/iovns/blob/4eacb6792f772669e4c6593a63949b8747a6f7d4/Makefile#L3-L12. Let's keep this issue here until we have a node running and test the issue.

davepuchyr commented 4 years ago

{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "node_info": {
      "protocol_version": {
        "p2p": "7",
        "block": "10",
        "app": "0"
      },
      "id": "61e1f6d195f022cab0fe18f2ac1a4d33430999eb",
      "listen_addr": "tcp://0.0.0.0:26656",
      "network": "iovns",
      "version": "0.33.0",

... I believe that "app": "0" means that we need the tech from https://github.com/iov-one/weave/pull/1194.

davepuchyr commented 4 years ago

@orkunkl, let's construct the app version info as 10000 major + 100 minor + patch, so v1.93.4 would yield app version 19304, for example.

orkunkl commented 4 years ago

I've made the implementation on cosmos-sdk but I'm sure even if we get this PR approved, it will take time to get this feature released soon. So instead we should fork cosmos-sdk as private repo and merge the changes there. @davepuchyr can you?

davepuchyr commented 4 years ago

Let's wait until it's publicly announced that we're using cosmos-sdk. I didn't know that it would be such a big deal to add this nice to have feature. I know that it's unsatisfying to leave work in a "pending" state, but we want to stay in stealth mode until we can deliver to all of our stakeholders.