iov-one / weave

Easy-to-use SDK to build Tendermint ABCI applications
https://weave.iov.one/docs/intro.html
Other
1.12k stars 47 forks source link

Implement BIP-39 #929

Closed husio closed 4 years ago

husio commented 4 years ago

As developer, I want to implement BIP 39 spec instead of using https://github.com/tyler-smith/go-bip39, so that we do not have to rely on inconsistent and abandoned software with bugs.

This issue is a result of learnings from implementing mnemonic support in bnscli. Used bip-39 package contains bugs and it is not updated for more than a year. If we have time, we should consider either fork & fix or implementing the spec from scratch.

Acceptance criteria

ruseinov commented 4 years ago

To be fair, there are some other go implementations already: https://github.com/bgadrian/go-mnemonic/tree/master/bip39 https://github.com/islishude/bip39 https://github.com/landonia/crypto

kmw101 commented 4 years ago

Not required as the bnscli is not going to be launched to mainnet