docker: ubuntu: remove py2 package and build 22.04 docker image

iovisor / bcc

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more

Apache License 2.0

20.36k stars 3.86k forks source link

docker: ubuntu: remove py2 package and build 22.04 docker image #4822

Closed ader1990 closed 9 months ago

ader1990 commented 10 months ago

This change was required because current stable Ubuntu versions have limited support for Python 2.7 (EOL 2020) and the upcoming ones do not even have Python 2.7 (Ubuntu 23 and Ubuntu 24 do not support it).

Code changes:

remove python3-bcc package and use python 3 for the python-bcc
remove python2 packages
remove Ubuntu 18/20 deb Dockerfile support and add 22.04 support
use clang / llvm 11, supported by Ubuntu 22.04

yonghong-song commented 10 months ago

@ader1990 Could you add some commit messages to the patch itself and also put here in the description box? I would like you describe

what is the purpose of the change
what kind of changes are made to accomplish that purpose
any special notes to users/reviewers
anything else you feel will be useful to the community

Thanks.

ader1990 commented 10 months ago

@ader1990 Could you add some commit messages to the patch itself and also put here in the description box? I would like you describe

what is the purpose of the change

what kind of changes are made to accomplish that purpose

any special notes to users/reviewers

anything else you feel will be useful to the community

Thanks.

Sure, will do it asap. Codewise, is it fine to merge the PR?

Thank you.

ader1990 commented 10 months ago

@yonghong-song I ammended the commit message and PR description. Will you consider enabling the https://github.com/iovisor/bcc/blob/master/.github/workflows/publish.yml to publish the Docker image quay.io/iovisor/bcc:latest if my PR is merged?

Thanks.

yonghong-song commented 9 months ago

Okay, we already moved beyond ubuntu 18.04, so agree that let us move to python3 and move to newer compilers like at least llvm11.

yonghong-song commented 9 months ago

@yonghong-song I ammended the commit message and PR description. Will you consider enabling the https://github.com/iovisor/bcc/blob/master/.github/workflows/publish.yml to publish the Docker image quay.io/iovisor/bcc:latest if my PR is merged?

Merged the pull request. What do you need me to do to enable https://github.com/iovisor/bcc/blob/master/.github/workflows/publish.yml to publish the Docker image quay.io/iovisor/bcc:latest?

ader1990 commented 9 months ago

quay.io/iovisor/bcc:latest

Thank you @yonghong-song. It would be great to have an updated docker image published, yes.

ader1990 commented 9 months ago

quay.io/iovisor/bcc:latest

Thank you @yonghong-song. It would be great to have an updated docker image published, yes.

It matters less if it is on quay, or dockerhub or ghcr.io.