search

iovisor / bcc

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more
Apache License 2.0
20.36k stars 3.86k forks source link

libbpf-tools: Fix llx printf modifiers in futexctn #4836

Open captain5050 opened 9 months ago

captain5050 commented 9 months ago

Fix llx printf modifiers by using inttypes.h's PRIx64.

yonghong-song commented 9 months ago

In libbpf-tools/javagc.c, we already have

javagc.c:       while (fscanf(f, "%zx-%zx %s %zx %*s %*d%[^\n]\n",

So '%zx' should work in your case. To preserve the code consistency, could you use '%zx' style instead?

yonghong-song commented 9 months ago

BTW, this patch has conflict with latest futexctn.c. You need to rebase your patch on the top of latest master branch.