search

iovisor / bcc

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more
Apache License 2.0
20.59k stars 3.88k forks source link

libbpf-tools/tcptop: Fix PID column alignment when pids are large #4986

Closed bernhardkaindl closed 1 month ago

bernhardkaindl commented 6 months ago

GitHub CI fails on a few test cases (flaky) so I added a minor commits to make CI less flaky.

Also, simply use return to return from a test case, as sys.exit() works by raising and Exception that is shown when Exceptions are traced like in the test environment.

yonghong-song commented 6 months ago

Looks like you have 5 commits but it seems only the first commit is relevant to this pull request. Could you rebase on top of master and re-push the pull request?

bernhardkaindl commented 1 month ago

Split into #5004 and #5005.

No yet split are the improvements to return instead of sys.exit() to cause nicer exit printing sys.exit() raises an exception, which prints a stack backtrace when run under monitoring of exceptions like in the test execution.