search

iovisor / bcc

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more
Apache License 2.0
20.59k stars 3.88k forks source link

libbpf-tools: add cpu filter for hardirqs/softirqs #5107

Closed ZhangYet closed 1 month ago

ZhangYet commented 2 months ago

Since tools/hardirqs and tools/softirqs supports a --cpu option, it's reasonable to support a same option in libbpf version.

ZhangYet commented 1 month ago

There are a lot of format issues as well. Please check

  • leading 'tab' instead of 'space'.
  • some places having trailing spaces. Please fix.

Sorry for the format issues. I kept switching development env between office and home, sometimes the fix was forget to push(like the space between { and cpu). I have replace all 8 space with tabs now.

Maybe we should provide a tool like checkpatch.el to do the format work?

yonghong-song commented 1 month ago

There are a lot of format issues as well. Please check

  • leading 'tab' instead of 'space'.
  • some places having trailing spaces. Please fix.

Sorry for the format issues. I kept switching development env between office and home, sometimes the fix was forget to push(like the space between { and cpu). I have replace all 8 space with tabs now.

Maybe we should provide a tool like checkpatch.el to do the format work?

Yes, it would be good if we have a checkpatch tool for all codes under libbpf-tools directory.