feat: bump bpftrace version to v0.19.1

iovisor / kubectl-trace

Schedule bpftrace programs on your kubernetes cluster using the kubectl

MIT License

2.04k stars 165 forks source link

feat: bump bpftrace version to v0.19.1 #205

Closed cakemanny closed 2 months ago

cakemanny commented 5 months ago

This resolves #200

It bumps the bptrace version to v0.19.1 .

I chose 0.19.1 as it's the most recent quay.io/iovisor/bpftrace tag. (It seems they are working on switching to using a Nix based build for later versions). I wasn't able to successfully able to bump bcc.

The other changes are related to

getting the Github Actions to run in the forked repo - i.e. $GIT_ORG is expanded in integration tests
getting the integration tests to pass with more recent versions of Minikube and Kind.
- I ended up bumping the version of go in order to be able to debug locally, so I hope it's ok that that's included also.

By all means let me know if it needs additional touches or splitting out into separate PRs.

PS: also fixes #174

cakemanny commented 5 months ago

~It seems the github actions are actually failing still, I'll have to come back to this. I've put in draft mode for now. I also tried to follow the instructions for signing the commits but for some reason they're showing as unverified so I'll have to revisit that too.~

Now fixed. I'd simply gone a bit too far with the go builder base image; switching from bookworm back to bullseye sorted that. I also added something to output pod log contents when a test case fails.

cakemanny commented 4 months ago

@fntlnz, would you be the one to look at this?

fntlnz commented 4 months ago

Thanks @cakemanny - This was long due. I'll take a look

fntlnz commented 3 months ago

I'm still looking into this @cakemanny - I did not forget! Thanks again !

cakemanny commented 2 months ago

Hey @fntlnz, I guess you've still not had time? Or is there something I can do to help, such as break parts out or explain better anything that looks a bit mysterious?

fntlnz commented 2 months ago

@cakemanny yes it's just my schedule the PR looks good to review, please hang on and thanks again for the great work.