This pull request includes changes to improve the testing workflow and compatibility for Windows. The most important changes include updating the test commands in the GitHub Actions workflow, adding a new test script for Windows, and modifying the CMakeLists files to better handle paths on Windows.
GitHub Actions workflow changes:
.github/workflows/windows.yml: The test command was updated to use CTest instead of the previous bpf_conformance tests. This simplifies the testing process and should be more reliable.
Windows compatibility improvements:
custom_tests/CMakeLists.txt: Changes were made to the foreach(test_file ${test_descr_files}) section to handle file paths differently on Windows. Forward slashes in the paths are replaced with backslashes, and a new Windows-specific test command was added.
ubpf_plugin/CMakeLists.txt: The PLUGIN_PATH variable was updated to handle Windows paths correctly. This change was made in the if(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64 AND (NOT CMAKE_HOST_SYSTEM_PROCESSOR section.
Additional changes:
Testing/Temporary/CTestCostData.txt: This file was added, but it only contains a single line (---). It's unclear what the purpose of this file is without more context.
coverage: 81.344%. remained the same
when pulling d7e3de16f8a76e5accf39cc43536eccb3257b0b9 on Alan-Jowett:run_ctest_on_windows
into 637d984ee91f142170e22129ccf2ef92f2af5b09 on iovisor:main.
coverage: 81.344%. remained the same
when pulling 746bdad33b6a71e95c55d3df948703c1c7b64f97 on Alan-Jowett:run_ctest_on_windows
into 637d984ee91f142170e22129ccf2ef92f2af5b09 on iovisor:main.
coverage: 81.344%. remained the same
when pulling 32aef870e88420f7845d81a0d61b6c3441a6403c on Alan-Jowett:run_ctest_on_windows
into 637d984ee91f142170e22129ccf2ef92f2af5b09 on iovisor:main.
This pull request includes changes to improve the testing workflow and compatibility for Windows. The most important changes include updating the test commands in the GitHub Actions workflow, adding a new test script for Windows, and modifying the CMakeLists files to better handle paths on Windows.
GitHub Actions workflow changes:
.github/workflows/windows.yml
: The test command was updated to use CTest instead of the previousbpf_conformance
tests. This simplifies the testing process and should be more reliable.Windows compatibility improvements:
custom_tests/CMakeLists.txt
: Changes were made to theforeach(test_file ${test_descr_files})
section to handle file paths differently on Windows. Forward slashes in the paths are replaced with backslashes, and a new Windows-specific test command was added.custom_tests/windows/test.cmd
: This new file was added to provide a Windows-compatible test command.ubpf_plugin/CMakeLists.txt
: ThePLUGIN_PATH
variable was updated to handle Windows paths correctly. This change was made in theif(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64 AND (NOT CMAKE_HOST_SYSTEM_PROCESSOR
section.Additional changes:
Testing/Temporary/CTestCostData.txt
: This file was added, but it only contains a single line (---
). It's unclear what the purpose of this file is without more context.