search

iovxw / ksni

A Rust implementation of the KDE/freedesktop StatusNotifierItem specification
The Unlicense
73 stars 11 forks source link

Add 'id' function into example program #18

Closed hwittenborn closed 1 year ago

hwittenborn commented 1 year ago

The 'id' function was previously missing in the example, but it's needed in order for the menu to pop up on Ubuntu-based distros (I'm not sure if other distros are affected, I just run Ubuntu and know it's affecting at least Ubuntu 22.10/23.04).

The only reason I knew that adding the 'fn id()' call would fix the issue is because of https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/320, but I think having an ID listed by default would be a good idea - I can't see any downsides to it anyway.

hwittenborn commented 1 year ago

Not sure if it'd be a good idea to make a note on the docs for the fn id() declaration in the source code itself, I just thought I'd throw this PR out there to see what you'd think would be best.

iovxw commented 1 year ago

Thank you, I'll add a note to the docs