search

iovzt / oauth-php

Automatically exported from code.google.com/p/oauth-php
MIT License
0 stars 0 forks source link

get_authorize_params shouldn't send errors #61

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Separation of concerns would dictate that this method simply get the 
parameters, not perform the redirect with an error response.  A separate method 
should handle the error as a result, or possibly a boolean(=true) parameter 
could be added to the function definition to maintain backwards compatibility.

This would promote flexibility without requiring someone to override the 
method.  For instance, I may want to allow a scope parameter that's 
comma-separated rather than space separated (a la Facebook)and there's no hook 
for me to do so with the class as defined.

Original issue reported on code.google.com by keithmno...@gmail.com on 28 Aug 2010 at 7:23

GoogleCodeExporter commented 8 years ago 
Ahn, are you sure you are talking about this project? There's no 
'get_authorize_params' anywhere in the code. Could you please elaborate?

Original comment by brunobg%...@gtempaccount.com on 30 Aug 2010 at 2:19

GoogleCodeExporter commented 8 years ago

Original comment by brunobg%...@gtempaccount.com on 10 Sep 2010 at 7:05