search

ip-v8 / rust-ipv8

Rust implementation of the IPv8 application.
https://ip-v8.github.io/rust-ipv8/ipv8
GNU Lesser General Public License v3.0
13 stars 2 forks source link

implement Bloom filter datastructure in rust #13

Closed ichorid closed 5 years ago

ichorid commented 5 years ago

https://github.com/Tribler/py-ipv8/blob/master/ipv8/messaging/bloomfilter.py

ichorid commented 5 years ago

@dsluijk please, look for existing implementations of stuff in C and Rust, instead of doing it by yourself. This will save you a lot of effort. Copy the code if it is license-compatible, or reimplement if it is not.

jdonszelmann commented 5 years ago

@ichorid Could you maybe explain to us what py-ipv8 (or tribler?) actually uses the bloom filter for? As far as we could see you only use it in your tests but not in the actual py-ipv8 logic. image

ichorid commented 5 years ago

It was extensively used by Dispersy, which is gone now. Still, some unused stuff from it remains. If see it is not used in the code, please, file a PR for cleaning it completely from IPv8.

ichorid commented 5 years ago

There's a lot of unused stuff in Tribler and IPv8. As you guys are going deeper, you will encounter a lot of cruft. Feel free to question the necessity of its existence, and kill it with fire if you are 100% sure it is dead code!

jdonszelmann commented 5 years ago

filing PR

ichorid commented 5 years ago

As soon as that will merge, you can close this one :wink:

jdonszelmann commented 5 years ago

:ok_hand:

jdonszelmann commented 5 years ago

https://github.com/Tribler/py-ipv8/pull/477

jdonszelmann commented 5 years ago

merged :D