search

ip-v8 / rust-ipv8

Rust implementation of the IPv8 application.
https://ip-v8.github.io/rust-ipv8/ipv8
GNU Lesser General Public License v3.0
13 stars 2 forks source link

rustfmt #37

Closed NULLx76 closed 5 years ago

NULLx76 commented 5 years ago

This pull requests formats all codes according to the rust style guide with help of rustfmt with very basic config (as can be seen in .rustfmt.toml).

This pull request also serves as a place to discuss which config options we may want to enable/disable or if we even want to use rustfmt at all.

We should also add this to CI to actually enforce the formatting if or when we agree what settings to exactly use.

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 30ba221c and detected 0 issues on this pull request.

View more on Code Climate.

codecov-io commented 5 years ago

Codecov Report

Merging #37 into develop will decrease coverage by 5.35%. The diff coverage is 93.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #37      +/-   ##
===========================================
- Coverage    89.98%   84.62%   -5.36%     
===========================================
  Files           19       19              
  Lines         1018     1145     +127     
===========================================
+ Hits           916      969      +53     
- Misses         102      176      +74
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (+100%) :arrow_up:
src/error.rs 0% <0%> (-9.26%) :arrow_down:
src/payloads/timedistributionpayload.rs 100% <100%> (ø) :arrow_up:
src/networking/address.rs 100% <100%> (ø) :arrow_up:
src/payloads/puncturepayload.rs 100% <100%> (ø) :arrow_up:
src/payloads/puncturerequestpayload.rs 100% <100%> (ø) :arrow_up:
src/serialization/bits.rs 100% <100%> (ø) :arrow_up:
src/payloads/connectiontype.rs 78.57% <72.72%> (ø) :arrow_up:
src/crypto/keytypes.rs 81.06% <78.81%> (-3.07%) :arrow_down:
src/serialization/varlen.rs 87.6% <87.06%> (+1.88%) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffe9c8b...30ba221. Read the comment docs.