ip2k / google-api-ruby-client

Automatically exported from code.google.com/p/google-api-ruby-client
Apache License 2.0
0 stars 0 forks source link

Next page tokens not being escaped #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Make a 'list' request with a page size smaller than the total number of items
2. Use .next_page on the result to obtain a reference for the next page
3. Make a request with the obtained reference

What is the expected output? What do you see instead?
Expected: working request on all cases where a next page token is available
Instead: failing request when the next page token includes a "+" character

What version of the product are you using? On what operating system?
Client library v0.3.0, Ubuntu 10.4

Please provide any additional information below.
An analysis of the request being sent seems to indicate that the next page 
token isn't being URL escaped, and thus the "+" characters are being 
interpreted as spaces.

Original issue reported on code.google.com by sergio.gomes%google.com@gtempaccount.com on 9 Dec 2011 at 9:01

GoogleCodeExporter commented 9 years ago

Original comment by bobaman@google.com on 10 Jan 2012 at 7:11

GoogleCodeExporter commented 9 years ago
This issue seems to have been fixed with the move to Faraday.

Original comment by sergio.gomes%google.com@gtempaccount.com on 17 Apr 2012 at 12:50

GoogleCodeExporter commented 9 years ago
Actually, I think someone checked in an explicit fix for it, but I never 
verified that it worked, so I left this issue open. However, to avoid 
regressions, it'd be greatly appreciated if you could put together a patch with 
a test to ensure it doesn't ever sneak back in.

Original comment by bobaman@google.com on 17 Apr 2012 at 1:01

GoogleCodeExporter commented 9 years ago
Good idea, I'll take care of it.

Original comment by sergio.gomes%google.com@gtempaccount.com on 17 Apr 2012 at 2:45

GoogleCodeExporter commented 9 years ago
Thanks, patch accepted and committed.

Original comment by bobaman@google.com on 24 Apr 2012 at 11:49

GoogleCodeExporter commented 9 years ago
This issue still exists in 0.4.7. Specifically, when a pageToken parameter 
includes a "+" character (ie. derived from a previous request's nextPageToken 
that includes a "+"), the "+" is not escaped in the subsequent request sent by 
the transmit method.

Original comment by hzan...@gmail.com on 19 Oct 2012 at 6:57