search

ip2k / google-api-ruby-client

Automatically exported from code.google.com/p/google-api-ruby-client
Apache License 2.0
0 stars 0 forks source link

Launchy may not correctly open a browser on Windows #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It appears that Launchy is dropping everything from the URL after the first '&' 
character.  Might require a patch to Launchy.

Original issue reported on code.google.com by bobaman@google.com on 30 Nov 2010 at 6:54

GoogleCodeExporter commented 9 years ago

Original comment by bobaman@google.com on 4 May 2011 at 12:26

GoogleCodeExporter commented 9 years ago

Original comment by bobaman@google.com on 12 May 2011 at 8:28

GoogleCodeExporter commented 9 years ago 
I can confirm this. I can also confirm that Launchy 2.0 is adding extraneous 
characters when parsing the uri.

I think it'd be best to remove the Launchy dependency and just print the url to 
the console for the developer to paste into the browser. This worked well for 
me and I can submit a patch (I just submitted a CLA) if this sounds good.

Thanks!
Chris

Original comment by chris.m....@gmail.com on 20 Jul 2011 at 4:56

GoogleCodeExporter commented 9 years ago 
I won't remove the Launchy dependency for non-Windows OSes, but if you want to 
pull together a patch that detects Windows and prints to console as a temporary 
work-around, I'd be OK with that.

Original comment by bobaman@google.com on 20 Jul 2011 at 5:19

GoogleCodeExporter commented 9 years ago 
Hi Bob, thanks for the response. I'm not understanding the need for OS 
detection? I'm on a Mac and am having the Launchy issue. Thanks!

Original comment by chris.m....@gmail.com on 20 Jul 2011 at 6:02

GoogleCodeExporter commented 9 years ago 
Oh? Really? I'm also on a Mac and it works fine for me. What browser are you 
using, and could you go into more detail about these 'extraneous' characters? 
Because the original bug was an issue of characters being omitted, not added.

Original comment by bobaman@google.com on 20 Jul 2011 at 6:57

GoogleCodeExporter commented 9 years ago 
When using Launchy 0.3.2, it launches the browser with only the client_id 
parameter: `https://accounts.google.com/o/oauth2/auth?client_id=MY_CLIENT_ID`.

When using Launchy 2.0.3, it launches the browser with extraneous escaped 
backslashes, "%5C": 
`https://www.google.com/accounts/o8/oauth2/authorization%5C?client_id%5C=MY_CLIE
NT_ID%5C&redirect_uri%5C=http://localhost:12736/%5C&response_type%5C=code%5C&sco
pe%5C=https://www.googleapis.com/auth/prediction`. This results in a "The 
server could not process you request" error.

If you're using a different version of Launchy, maybe you could just lock the 
gem to the specific version of Launchy that works.

I think this is because of Launchy, but the rest of my setup is, Mac OS 10.6.7, 
Chrome 12, and Ruby 1.9.2p180.

Original comment by chris.m....@gmail.com on 20 Jul 2011 at 8:06

GoogleCodeExporter commented 9 years ago 
Yeah, definitely a Launchy issue, and I may need to submit patches to their 
project to resolve this one.

Original comment by bobaman@google.com on 10 Jan 2012 at 7:48

GoogleCodeExporter commented 9 years ago 
Didn't verify, but looking back at Launchy closed bugs this was fixed back ~ 
2.0.4. Currently using >= 2.1.1. Marking as fixed/obsolete.

Original comment by sba...@google.com on 3 Jan 2013 at 12:48