ipa320 / cob_android

Apache License 2.0
2 stars 10 forks source link

do not use sub folder for installed scripts #29

Closed floweisshardt closed 7 years ago

floweisshardt commented 7 years ago

follow-up PR from #28 and adressing @ipa-mdl's suggestion

fmessmer commented 7 years ago

the problem is that the script is also installed in the setup.py....which leads to file-exists errors sometimes...which is why I removed the install tag recently...maybe I should have removed it feom setup.py instead...

greetings from civilization...trenta, slovenia...

floweisshardt commented 7 years ago

greeting back @ipa-fxm: hope you enjoy your trip and miss the robots already :-)

so what's you suggestion? merge or remove from setup.py?

mathias-luedtke commented 7 years ago

merge or remove from setup.py?

both!

benmaidel commented 7 years ago

added PR to fmw's patch branch https://github.com/ipa320/cob_android/pull/30

floweisshardt commented 7 years ago

FR: OK