cleanup packages and migrated to package.xml 2 format

ipa320 / cob_android

Apache License 2.0

2 stars 10 forks source link

Closed benmaidel closed 9 years ago

benmaidel commented 9 years ago

this pr includes fixes to install tags and also the cob_arc android apk

do not add the apk to the install tags because this app should not be delivered by debian pkgs

floweisshardt commented 9 years ago

fixes #7 @ipa-fxm and @ipa-nhg please review

fmessmer commented 9 years ago

BTW, while we are on it, can we cleanup the package.xml and the CMakeLists.txt of all cob_android packages? E.g. in https://github.com/ipa320/cob_android/blob/indigo_dev/cob_android_msgs/CMakeLists.txt there are a lot of comments that are copy-and-pasted from the cob_script_server...

benmaidel commented 9 years ago

i have removed the wrong install tags and cleaned up all packages. I think this PR should now be fine.

fmessmer commented 9 years ago

are you migrating to package.xml format 2 in a separate PR? I think it's ok to do it with this one...

benmaidel commented 9 years ago

yes, format 2 will be a separate PR

benmaidel commented 9 years ago

ok finally, i hope this pr is now clean

fmessmer commented 9 years ago

Thanks for taking this effort...LGTM

benmaidel commented 9 years ago

i've tested the install tags and they work as expected. So this means the catkin_install_python makro seems to work fine

ipa-nhg commented 9 years ago

Test on cob4-2: OK

fmessmer commented 9 years ago

LGTM