search

ipa320 / cob_gazebo_plugins

Apache License 2.0
9 stars 17 forks source link

[Melodic] #38

Closed benmaidel closed 5 years ago

benmaidel commented 5 years ago

ref https://github.com/ipa320/care-o-bot/issues/52

superseeds https://github.com/ipa320/cob_gazebo_plugins/pull/37

I've removed the last commit from @ompugao concerning the pid interface because of @fmessmer comment https://github.com/ipa320/cob_gazebo_plugins/pull/37#pullrequestreview-267692954

This should be compatible with kinetic and melodic if the hardware_interface prefix is used for all transmissions.

fmessmer commented 5 years ago

maybe we can do something like this: https://github.com/ros-simulation/gazebo_ros_pkgs/pull/550 to be compatible with both with and without prefix

fmessmer commented 5 years ago

@benmaidel please re-test this branch with melodic simulation to help me verify the dual-distro compatibility...thx