ipa320 / cob_manipulation

www.care-o-bot.org
Apache License 2.0
31 stars 57 forks source link

properly pass missing launch arguments #123

Closed fmessmer closed 7 years ago

fmessmer commented 7 years ago

some launch arguments were not properly passed through cob_moveit_bringup in order to be able to use cob_moveit_bringup together with a moveit_config package located in a different location

full backwards compatibility is guaranteed through proper default values...

fmessmer commented 7 years ago
  1. During the roslaunch (roslaunch cob_moveit_bringup demo.launch) we have the following error: [ERROR] [1501604281.693737864]: Group 'robot' does not have a parent link

I guess you were using it with raw3-1? Then this points to something being wrong in cob_robots/cob_moveit_config for raw3-1 which is not related/touched by this PR

  1. When I change default planner in planning_pipeline.xml from OMPL to something else, e.g. chomp, stomp, etc. It is not modified in RVIZ. The second comment only applies if other planners were working properly before.

chomp and stomp are currently not supported in cob_robots/cob_moveit_config...I assume your local branch of cob_robots is out of date

bbrito commented 7 years ago

Well the group robot was created to simulate whole-body trajectories.

Please use just the group arm. If you have any problem talk with Mayank in my office because I will be out next week.

Otherwise once I'm back ;)

fmessmer commented 7 years ago

guys, this is no support forum...I simply requested a review of the PR :wink: