ipa320 / cob_manipulation

www.care-o-bot.org
Apache License 2.0
31 stars 57 forks source link

additional arguments for moveit_config helper #128

Closed fmessmer closed 6 years ago

fmessmer commented 6 years ago

you can now pass additional arguments to the helper, i.e. pkg_moveit_config_name and pkg_hardware_config_name, in order to use the helper to generate and update moveit_configs at other locations as well - as long as they follow the cob_moveit_config structure (defaults are still cob_moveit_config and cob_hardware_config if the additional arguments are not set)

@ipa-aep @ipa-bfb please review/test

also: fixes https://github.com/ipa320/cob_manipulation/issues/105 see https://github.com/ipa320/cob_manipulation/issues/105#issuecomment-338577913

fmessmer commented 6 years ago

ping @ipa-bfb @ipa-aep please review

@ipa-jba @ipa-fez can I get admin access to this repo...things do not get reviewed here...

fmessmer commented 6 years ago

@ipa-mdl do you approve now that I proposed ipa320/cob_robots#729?

mathias-luedtke commented 6 years ago

@ipa-fxm: please test my latest patch