Closed ipa-jsf closed 9 years ago
The cob_perception_common
package in this repo is a meta-package!
There should not be any code file in it!
`cob_vision_utils``is probably the better location for StdAfx.h and Co...
More review to come after the first issues have been adressed... Should not be merged like this!
@ipa-fmw: Concerning StdAfx.h file and relative paths: StdAfx is a precompiled header file, that is used under Windows to speed up compilation. Under Linux it is ignored (see the preprocessor directives). The path to the header file must be the first line of code, therefore I cannot put it in between the windows preprocessor tags, and therefore the path is expressed relative.
I know, there could be problems when installing the package, because the path may no longer be valid. I will check under visual studio if I can properly set an additional include path in order to comply with the ROS syntax.
@ipa-fxm Fixed issue with precompiled header files
I'm still not sure, why the commits for this PR contain commits referring to merging with ELECTRIC?
@ipa-fxm Me neither, but I pulled from ipa320/groovy_dev and ipa320/indigo_dev before comitting. Should be alright.
LGTM then...
visual review: Ok
indigo_dev build. Merged changes from hydro_dev. Successfully build and catkin_lint it @ipa-fxm Please Review