ipa320 / cob_perception_common

Apache License 2.0
13 stars 59 forks source link

Move 3d mapping msgs #60

Closed fmessmer closed 8 years ago

fmessmer commented 8 years ago

@ipa-rmb FYI let's merge once everything is settled:

I'll keep you updated!

fmessmer commented 8 years ago

@ipa-rmb Quick question: I don't like to much that cob_perception_common now depends on cob_object_perception (because cob_3d_mapping_msgs depends on cob_object_detection_msgs). Should we also move cob_object_detection_msgs into cob_perception_common to have all message definitions here in cob_perception_common?

ipa-rmb commented 8 years ago

It is already there :-)

fmessmer commented 8 years ago

ups, my bad!

Can you then please give the combo

a quick test whether it works as expected? It should not have any effect on cob_object_perception...

ipa-rmb commented 8 years ago

It compiles on my machine. I do not have a quick test but it looks good. We can merge it.

fmessmer commented 8 years ago

compiles on my machine and travis is happy, too....feel free to merge the two PRs...I'll then continue to fix cob_scenario_states