Closed fmessmer closed 8 years ago
@ipa-rmb
Quick question: I don't like to much that cob_perception_common
now depends on cob_object_perception
(because cob_3d_mapping_msgs
depends on cob_object_detection_msgs
). Should we also move cob_object_detection_msgs
into cob_perception_common
to have all message definitions here in cob_perception_common
?
It is already there :-)
ups, my bad!
Can you then please give the combo
a quick test whether it works as expected?
It should not have any effect on cob_object_perception
...
It compiles on my machine. I do not have a quick test but it looks good. We can merge it.
compiles on my machine and travis is happy, too....feel free to merge the two PRs...I'll then continue to fix cob_scenario_states
@ipa-rmb FYI let's merge once everything is settled:
cob_perception_common
: done in this PRcob_environment_perception
: https://github.com/ipa320/cob_environment_perception/pull/35cob_object_perception
: nothing to be done, issue tracked in https://github.com/ipa320/cob_object_perception/issues/43cob_scenario_states
I'll keep you updated!