Removed unnecessary cmake_modules

ipa320 / cob_perception_common

Apache License 2.0

13 stars 59 forks source link

Removed unnecessary cmake_modules #79

Closed ipa-rmb closed 7 years ago

ipa-rmb commented 7 years ago

Before merging, how do I remove the unnecessary commits (those without any effect) that were squashed in the last PR?

fmessmer commented 7 years ago

this time: git rebase origin-320/indigo_dev next time: start using feature-branches :wink:

fmessmer commented 7 years ago

Hmm, I tested the github rebase&merge option...it did the right thing: rebase...but I guess squashing would have been better as now the add-modify-remove grasp service part is included as well.... one more argument for only providing properly cleaned-up, squashed and rebased PRs from a feature-branch :stuck_out_tongue_winking_eye:

fmessmer commented 7 years ago

@ipa-rmb could you re-release cob_perception_common for both indigo and kinetic as your fix fixes a few things on the build farm...

bbrito commented 7 years ago

@ipa-rmb Where is the grasping service now? We need it for the picking scenario...

ipa-rmb commented 7 years ago

back in order picking