[image_flip] fix image flip to support ROS coordinate system convention

ipa320 / cob_perception_common

Apache License 2.0

13 stars 59 forks source link

[image_flip] fix image flip to support ROS coordinate system convention #84

Closed floweisshardt closed 6 years ago

floweisshardt commented 6 years ago

we found out that we're currently not conform with the ROS coordinate system convention. see https://github.com/ipa320/cob_robots/issues/669. Thus the current implementation of the image_flip node is not correct.

we should fix image_flip to be aligned with http://www.ros.org/reps/rep-0103.html
and fix the (wrong) Asus camera systems see https://github.com/ipa320/cob_robots/issues/669

fmessmer commented 6 years ago

I don't think it is a problem of image_flip...for cob4-12 the calibration_default parameters were not correct for the zr300 cameras...I fixed this in unity-robotics/unity-robots#8...then, I can use image flip in mode 1 with the angle set to 0 no matter what the camera orientation is....

@ipa-fmw please re-open if you think otherwise...