search

ipa320 / cob_perception_common

Apache License 2.0
13 stars 59 forks source link

update to use non deprecated pluginlib macro #86

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

This macro, deprecated for now 8 years, will be removed in the next ROS release (ROS Melodic)

fmessmer commented 6 years ago

I took the liberty to also fix the second occurrence of this deprecated macro and amend it to your branch

mikaelarguedas commented 6 years ago

I took the liberty to also fix the second occurrence of this deprecated macro and amend it to your branch

Thanks! It didnt show up in my search because I looked only for packages declaring a dependency on pluginlib. Looks like cob_image_flip fails to declare this dependency in its' package manifest.

Edit: To clarify, the dependency on pluginlib is exported through nodelet so it should not be necessary for these packages to explicitly depend on pluginlib. It's just that my search was not broad enough

fmessmer commented 6 years ago

well, it's cleaner to declare the dependency explicitly rather than rely on transitive dependencies...see https://github.com/ipa320/cob_perception_common/pull/87